Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show default settings in mysql sample config #6484

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Show default settings in mysql sample config #6484

merged 1 commit into from
Oct 22, 2019

Conversation

danielnelson
Copy link
Contributor

The sample config now shows the default values. I added new defaults for the perf events since the existing defaults were not usable and the plugin required them to be set.

  # perf_events_statements_digest_text_limit = 120
  # perf_events_statements_limit = 250
  # perf_events_statements_time_limit = 86400

closes #6444

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added docs Issues related to Telegraf documentation and configuration descriptions area/mysql fix pr to fix corresponding bug labels Oct 4, 2019
@danielnelson danielnelson modified the milestones: 1.12.3, 1.13.0 Oct 4, 2019
glinton
glinton reviewed Oct 8, 2019
View reviewed changes
plugins/inputs/mysql/mysql.go
## gather thread state counts from INFORMATION_SCHEMA.PROCESSLIST
gather_process_list = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this (and others) negatively affect those generating and using the config file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give an example of what might happen?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the default/generated config file, so if anyone is relying on these values, telegraf will no longer do what they are expecting. In this case, the process list would no longer be gathered unless manual action is taken on their part, whereas before no action was required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, a newly generated config would be different from a generated config in the previous version. The reason I think this is okay is that previously generated configs will continue to work as before. The default values aren't changing (with the exception of the values in the first comment) they were documented incorrectly.

@danielnelson danielnelson merged commit acdfa1b into master Oct 22, 2019
@danielnelson danielnelson deleted the mysql-sample-config branch October 22, 2019 04:22
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
@danielnelson
Show default settings in mysql sample config (influxdata#6484)
159f1a8
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
@danielnelson
Show default settings in mysql sample config (influxdata#6484)
732c372
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@danielnelson
Show default settings in mysql sample config (influxdata#6484)
9b1d672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glinton glinton glinton left review comments

Assignees
No one assigned
Labels
area/mysql docs Issues related to Telegraf documentation and configuration descriptions fix pr to fix corresponding bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

MySQL defaults are not applied
2 participants
@danielnelson @glinton